[Libosinfo] [osinfo-db PATCH] install-script, windows: cdrom is also a viable injection method

Fabiano Fidêncio fidencio at redhat.com
Wed Jun 5 08:24:06 UTC 2019


On Wed, Jun 5, 2019 at 9:45 AM Fabiano Fidêncio <fidencio at redhat.com> wrote:
>
> For scripts being used on Windows Vista+ the unattended installer can
> also be used via cdrom and not only via a floppy device.
>
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>

Self-nack! I just found out we explicitly run a command for "A:\" in
one of the files.
A v2 will be sent soon.

> ---
> It's important to mention that this change is not going to break current
> consumers of those scripts.
>
> There are more changes to come when actively using the unattended
> script, together with pre/post installation of drivers ... but, right
> now, this patch is good enough for dropping mtools dependency on
> virt-manager together with floppy injection there (as virt-install still
> doesn't pre/post install drivers).
> ---
>  data/install-script/microsoft.com/windows-cmd-desktop.xml.in     | 1 +
>  .../install-script/microsoft.com/windows-unattend-desktop.xml.in | 1 +
>  data/install-script/microsoft.com/windows-unattend-jeos.xml.in   | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/data/install-script/microsoft.com/windows-cmd-desktop.xml.in b/data/install-script/microsoft.com/windows-cmd-desktop.xml.in
> index 7fee340..1be991e 100644
> --- a/data/install-script/microsoft.com/windows-cmd-desktop.xml.in
> +++ b/data/install-script/microsoft.com/windows-cmd-desktop.xml.in
> @@ -18,6 +18,7 @@
>        <param name="post-install-drivers-location" policy="optional"/>
>        <param name="driver-signing" policy="optional"/>
>      </config>
> +    <injection-method>cdrom</injection-method>
>      <injection-method>floppy</injection-method>
>      <avatar-format>
>        <mime-type>image/bmp</mime-type>
> diff --git a/data/install-script/microsoft.com/windows-unattend-desktop.xml.in b/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
> index b399bd0..7baebe8 100644
> --- a/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
> +++ b/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
> @@ -21,6 +21,7 @@
>      <param name="pre-install-drivers-location" policy="optional"/>
>      <param name="script-disk" policy="optional"/>
>     </config>
> +    <injection-method>cdrom</injection-method>
>      <injection-method>floppy</injection-method>
>      <template>
>       <xsl:stylesheet
> diff --git a/data/install-script/microsoft.com/windows-unattend-jeos.xml.in b/data/install-script/microsoft.com/windows-unattend-jeos.xml.in
> index 78b75db..f27dec1 100644
> --- a/data/install-script/microsoft.com/windows-unattend-jeos.xml.in
> +++ b/data/install-script/microsoft.com/windows-unattend-jeos.xml.in
> @@ -19,6 +19,7 @@
>        <param name="pre-install-drivers-disk" policy="optional"/>
>        <param name="pre-install-drivers-location" policy="optional"/>
>      </config>
> +    <injection-method>cdrom</injection-method>
>      <injection-method>floppy</injection-method>
>      <template>
>        <xsl:stylesheet
> --
> 2.21.0
>




More information about the Libosinfo mailing list