[Libosinfo] [osinfo-db-tools PATCH 1/8] tools: Don't import config.h
Daniel P. Berrangé
berrange at redhat.com
Thu Jun 20 16:50:55 UTC 2019
On Thu, Jun 20, 2019 at 05:21:20PM +0200, Fabiano Fidêncio wrote:
> As config.h is not used, at all, in osinfo-db-tools, let's just stop
> generating and including the file.
Not entirely true. It is used for the GETTEXT_PACKAGE macro. Fortunately
it seems that when you kill the AC_CONFIG_HEADER macro from configure,
it automatically switches to pass -DGETTEXT_PACKAGE=... as a compiler
arg instead so things still work
>
> Together with this change, let's also drop both sc_require_config_h and
> sc_require_config_h_first checks from `make syntax-check`.
>
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
> cfg.mk | 4 +++-
> configure.ac | 1 -
> tools/osinfo-db-export.c | 2 --
> tools/osinfo-db-import.c | 2 --
> tools/osinfo-db-path.c | 2 --
> tools/osinfo-db-util.c | 2 --
> tools/osinfo-db-validate.c | 2 --
> 7 files changed, 3 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
if you improve the commit message
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the Libosinfo
mailing list