[Libosinfo] [PATCH osinfo-db 08/10] tests: test_isoinfo: don't log in match()
Fabiano Fidêncio
fidencio at redhat.com
Wed Mar 20 08:02:04 UTC 2019
On Tue, Mar 19, 2019 at 9:02 PM Cole Robinson <crobinso at redhat.com> wrote:
>
> With the full test suite we hammer this function over 100K times.
> This logging call in fact causes a lot of slow down. Dropping it
> cuts time for me from ~120s to ~80s
>
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> tests/test_isoinfo.py | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/test_isoinfo.py b/tests/test_isoinfo.py
> index 9477942..8440bb2 100644
> --- a/tests/test_isoinfo.py
> +++ b/tests/test_isoinfo.py
> @@ -69,8 +69,6 @@ class _ISODataMedia():
> if volumesize == 0:
> volumesize = self.volumesize
>
> - logging.warning("media.volumeid: %s | self.volumeid: %s",
> - media.volumeid, self.volumeid)
Ouch, this was a debug log that I forgot to remove. /o\
[snip]
More information about the Libosinfo
mailing list