[Libosinfo] [PATCH osinfo-db 00/10] tests: misc improvements

[Cole Robinson]

On 3/20/19 4:05 AM, Fabiano Fidêncio wrote:
> On Tue, Mar 19, 2019 at 9:02 PM Cole Robinson <crobinso at redhat.com> wrote:
>>
>> This series is a handful of misc tests/ improvements
>>
>> * Makes style generally pep8/pylint clean, at least with my local cfg
>> * Makes manual invocation of 'pytest-3' work
>> * Rearranges the internal API to cache our XML parsing to save some
>>    test time
>> * Reduce test_isoinfo full runtime by ~95%
>>
> 
> For the whole series:
> Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>
> 
> (And I'm pushing them soon ...)
> 
> Shouldn't we have a way to enforce pep8/pylint, at least with your
> cfg, as part of the tests?
> 
> Thanks a lot for the whole work on this!
> 

I wouldn't enforce it, most of the issues reported are non-functional, 
and releases regularly introduce new checks, I wouldn't want to be 
blocked by that. Maybe a 'make' target to cover running it though. 
flake-8 might be a better target for that though, pylint is more 
powerful but requires some hand holding over time. Considering that this 
is just test code we probably don't need to worry about pylint much, I 
just have a local setup that's easy to run

- Cole