[Libosinfo] [PATCH osinfo-db 1/7] tests: test_isoinfo: Remove shortid from _ISODataMedia

Cole Robinson crobinso at redhat.com
Wed Mar 20 21:53:20 UTC 2019


It's unused, and conceptually it doesn't really belong to this class

Signed-off-by: Cole Robinson <crobinso at redhat.com>
---
 tests/test_isoinfo.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/test_isoinfo.py b/tests/test_isoinfo.py
index beebcd2..3476ea9 100644
--- a/tests/test_isoinfo.py
+++ b/tests/test_isoinfo.py
@@ -38,11 +38,10 @@ def test_iso_detection(_os):
 
 
 class _ISODataMedia():
-    def __init__(self, filename, shortid, volumeid, publisherid, systemid,
+    def __init__(self, filename, volumeid, publisherid, systemid,
                  applicationid, volumesize):
 
         self.filename = filename
-        self.shortid = shortid
         self.volumeid = volumeid if volumeid is not None else ''
         self.publisherid = publisherid if publisherid is not None else ''
         self.systemid = systemid if systemid is not None else ''
@@ -95,7 +94,7 @@ def _get_volumesize(string):
     return _get_value(string, 'Volume size is: ', int)
 
 
-def _get_isodatamedia(filepath, shortid):
+def _get_isodatamedia(filepath):
     volumeid = None
     publisherid = None
     systemid = None
@@ -123,7 +122,7 @@ def _get_isodatamedia(filepath, shortid):
     else:
         volumesize = None
 
-    return _ISODataMedia(filepath, shortid, volumeid, publisherid, systemid,
+    return _ISODataMedia(filepath, volumeid, publisherid, systemid,
                          applicationid, volumesize)
 
 
-- 
2.21.0




More information about the Libosinfo mailing list