[Libosinfo] [PATCH osinfo-db 00/15] tests: more tweaks

Fabiano Fidêncio fidencio at redhat.com
Mon Mar 25 20:51:43 UTC 2019


On Mon, Mar 25, 2019 at 3:32 PM Cole Robinson <crobinso at redhat.com> wrote:
>
> Another collection of test suite tweaks and improvements. FWIW
> I have another small series on top of this that adds a script
> which simplifies adding new test/isodata content, and it uses
> some of the test suite changes here.
>
> Thanks,
> Cole
>
> Cole Robinson (15):
>   tests: test_isoinfo: Remove unused function
>   tests: Rename test_validation -> test_schema
>   tests: test_schema: Drop redundant parametrize ids=
>   tests: Use 'osxml' as standard argument name
>   tests: Move 'requests' usage to test_urls
>   tests: test_urls: Combine the test cases
>   tests: test_resources: consolidate to one test case
>   tests: Sort input OS/files before testing
>   tests: osinfo: Actually use _cache_property as a decorator
>   tests: osinfo: Add a base class
>   tests: osinfo: Absorb the initial XML parsing
>   tests: test_devices: check for device name comment
>   tests: test_isoinfo: improve output on failure
>   tests: Use lxml
>   tests: Move isodata parsing to isodata.py
>
>  tests/isodata.py         |  91 ++++++++++++++++
>  tests/osinfo.py          | 219 ++++++++++++++++++---------------------
>  tests/test_devices.py    |  51 +++++++--
>  tests/test_isoinfo.py    | 134 +++---------------------
>  tests/test_resources.py  |  69 +++++-------
>  tests/test_schema.py     |  18 ++++
>  tests/test_urls.py       |  57 ++++++----
>  tests/test_validation.py |  18 ----
>  tests/util.py            |  67 ++++++++----
>  9 files changed, 375 insertions(+), 349 deletions(-)
>  create mode 100644 tests/isodata.py
>  create mode 100644 tests/test_schema.py
>  delete mode 100644 tests/test_validation.py

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>
(And pushed!)


>
> --
> 2.21.0
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo




More information about the Libosinfo mailing list