[Libosinfo] [PATCH 2/2] win7: Add virtual kbd & mouse to supported devices

[Zeeshan Ali (Khattak)]

On Wed, Apr 15, 2015 at 5:02 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Wed, Apr 15, 2015 at 04:01:46PM +0100, Zeeshan Ali (Khattak) wrote:
>> I don't think the inconsistency is significant enough and is not
>> actually introduced by these patches themselves. Libosinfo is just
>> saying "these devices are supported by the OS" with these patches and
>> if Boxes or qemu (or other apps) add a slightly different device based
>> on this information, that is not a fault of libosinfo.
>
> Yes, this would be Boxes/qemu faults for not following what libosinfo
> told it to and adding a USB mouse when libosinfo never told it this
> specific mouse was supported. In this patch what you really are trying
> to say is that it's able to support any USB mouse, not the VMWare one.

Huh? How so? Your last sentence is contradicting the previous one.

>> > So if we can do without because the bug is elsewhere, it's better imo.
>>
>> That would mean very slow keyboard and mouse in windows 8.1.
>>
>> The bug of XP installer crashing is not exactly somewhere else since
>> we at least know that it does not happen if you only remove USB mouse
>> and keyboard from Boxes generated domain configuration. As I said, its
>> likely a combination, USB mouse and keyboard being a part of that.
>
> Yes, but as Windows installs do not always crash with a USB mouse, it
> would be nice to narrow it down and report it against the right
> component (QEMU? something else?) rather than adding API in libosinfo to
> just paper over it.

Maybe but as I tried to explain before, the patches themselves are
good unless you have some objections on them (rather than how I intend
to use them). I'm not adding any API btw, just adding new data that is
not papering over anything on its own.

Besides, I really don't think its worth me spending even more hours
trying to debug what exactly is this magical combination that makes XP
break, keeping in mind that:

1. USB mouse and keyboard were never needed in XP and Boxes started
adding these devices specifically for Windows 8.1. I don't think any
other UI adds USB mouse and keyboard either.

2. Its likely an XP issues since other OSs are running fine with USB
keyboard and mouse and good luck filing bugs on XP and especially to
get them fixed in there.

3. XP is not even supported by Microsoft any more so would hate to
spend more time on this while my todo pile is going through the roof.

4. XP installation is already fixed (or worked around) in Boxes and
these patches are only needed now for making Windows 8.1 not having a
slow mouse and keyboard.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/