[Libosinfo] [PATCH 2/2] win7: Add virtual kbd & mouse to supported devices

[Christophe Fergeau]

On Thu, Apr 16, 2015 at 02:52:27PM +0100, Zeeshan Ali (Khattak) wrote:
> On Wed, Apr 15, 2015 at 5:02 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Wed, Apr 15, 2015 at 04:01:46PM +0100, Zeeshan Ali (Khattak) wrote:
> >> I don't think the inconsistency is significant enough and is not
> >> actually introduced by these patches themselves. Libosinfo is just
> >> saying "these devices are supported by the OS" with these patches and
> >> if Boxes or qemu (or other apps) add a slightly different device based
> >> on this information, that is not a fault of libosinfo.
> >
> > Yes, this would be Boxes/qemu faults for not following what libosinfo
> > told it to and adding a USB mouse when libosinfo never told it this
> > specific mouse was supported. In this patch what you really are trying
> > to say is that it's able to support any USB mouse, not the VMWare one.
> 
> Huh? How so? Your last sentence is contradicting the previous one.

This patch is adding a specific device definition (QEMU supports a
specific USB mouse provided by VMWare).
What you need/really want in this series is a way to say "QEMU supports
HID devices whose protocol is "Mouse" "

> Maybe but as I tried to explain before, the patches themselves are
> good unless you have some objections on them (rather than how I intend
> to use them).

Adding something which does not make a lot of sense with the explicit
goal of letting an application use that as meaning something different
than what is intended is not very compelling. I'd rather we provide
application developers with what they need.

> Besides, I really don't think its worth me spending even more hours
> trying to debug what exactly is this magical combination that makes XP
> break, keeping in mind that:

Well, it's sad that you are not interested in reporting a potential bug
in QEMU USB emulation, or memory corruption during virtio driver
installation, or ... This could be as much a WinXP bug as just a
symptom of a bug in something we can fix.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20150416/9dd7fd7a/attachment.sig>