[Libosinfo] [PATCH] Add a Windows 7 CD ID

[Zeeshan Ali (Khattak)]

Hi Yoshi,

Thanks for the patch. Some notes below:

On Fri, Dec 19, 2014 at 11:01 PM, Yoshi2889 <rick.2889 at gmail.com> wrote:
> ---
>  data/oses/windows.xml.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/oses/windows.xml.in b/data/oses/windows.xml.in
> index 38c8ae6..47d4457 100644
> --- a/data/oses/windows.xml.in
> +++ b/data/oses/windows.xml.in
> @@ -832,7 +832,7 @@
>      <!-- Variant unknown -->
>      <media arch="i686" installer-reboots="2">
>        <iso>
> -        <volume-id>(GRMCPRFRER)_</volume-id>
> +        <volume-id>(GRMCPRFRER|GRMCPRFREO)_</volume-id>

I see that you are adding under 'unknown' variant. If you have access
to the media, it should be easily possible to find out what variant it
is? Once you have figured the variant, please:

1. Add the volume id under the appropriate media entry
2. Specify the variant in git log

For the record, we actually never added 'unknown variant' medias to
our db but rather we had lots of volume ids and when we added the
concept of variants, we couldn't figure out what variants were some of
the medias.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/